docs(firebase_ui_auth): use a valid BuildContext in onSignedIn() to navigate correctly#589
Open
EchoEllet wants to merge 1 commit intofirebase:mainfrom
Open
docs(firebase_ui_auth): use a valid BuildContext in onSignedIn() to navigate correctly#589EchoEllet wants to merge 1 commit intofirebase:mainfrom
EchoEllet wants to merge 1 commit intofirebase:mainfrom
Conversation
…rrectly The current code snippet in the README does not function after logging in with any authentication provider and will produce a runtime error. This is due to using `Navigator` with the root widget's `BuildContext`, which lacks the details required to navigate to the profile screen, which is only known in a `BuildContext` that is under `MaterialApp`.
EchoEllet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current code snippet in the README of
firebase_ui_authdoes not function after logging in with any authentication provider and will produce a runtime error.This is due to passing the
BuildContextof the root app widget as an argument toNavigator.pushReplacementNamed(), which lacks the details required to navigate to the profile screen, which is only defined in aBuildContextthat is underMaterialApp.Checklist
///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change